COMP: Fix Qt6 build with tests #1325
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #include <QCoreApplication> | ||
| #include <QDebug> | ||
| #include <QDir> | ||
| #include <QRegExp> |
Contributor
There was a problem hiding this comment.
This can be used in a Qt6 build without Qt5Compat module?
Contributor
Author
There was a problem hiding this comment.
No, you're right, it requires qt5compat (though that seems to be available already in the according target, I didn't have to add it)
Other targets such as widgets use qt5compat too:
https://github.com/commontk/CTK/blob/master/Libs/Widgets/ctkConsole.cpp#L63
so maybe it gets pulled in via some dependency?
But in the long run the better fix is a replacement through QRegularExpression, so I will do that instead!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CTK build against Qt6 with tests (BUILD_TESTING) enabled - an include is missing.